Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: stop triggering CircleCI on automated pushes to gh-pages #151

Merged
merged 1 commit into from Aug 3, 2020

Conversation

consideRatio
Copy link
Member

@consideRatio consideRatio commented Aug 1, 2020

I noticed how there were failing builds in CircleCI. They were triggered by pushes to gh-pages, and complained that there were no .circleci/config.yml in there (in the gh-pages branch).

When I was trying to create a stub it required me to define a lot to not fail validation. So, instead I opt to disable the build by adding a "[skip ci]" within the commit message for the gh-pages branch made by the ghp-import CLI.

@@ -25,7 +25,7 @@ jobs:
name: Pushing documentation to gh-pages
command: |
pip install --user ghp-import
ghp-import -n -p docs/_build/html
ghp-import --no-jekyll --push --message "Update documentation [skip ci]" docs/_build/html
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to lookup what -n and -p meant, so I figure it made more sense to be explicit for a tool like ghp-import which isn't used frequently by everyone.

@yuvipanda yuvipanda merged commit bac2ad1 into jupyterhub:master Aug 3, 2020
@yuvipanda
Copy link
Contributor

Thanks, @consideRatio!

@consideRatio consideRatio added the ci label Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants