rewrite_response hook: (HTTP status) code updates should sometimes automatically update reason
#304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
|
Thanks @consideRatio, your comment is very nicely written. |
consideRatio
changed the title
code updates should sometimes automatically update reason
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an annoying discrepancy between Tornado's
HTTPResponseand myRewritableResponsewhen changing the HTTP code. In Tornado, the.reasonattribute defaults to the text corresponding to the.codeattribute. However, inRewritableResponse, we expect the.codeattribute to be changed. If you change.code, then.reasonretains the text generated for the previous code. In this PR, I add an observer which updates the.reasonattribute if.codehas changed and.reasonstill has its default value.I also extended the documentation to illustrate more of the functionality provided, and extended the tests accordingly.