Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link to contributing.md #291

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Fix link to contributing.md #291

merged 1 commit into from
Aug 30, 2021

Conversation

kinow
Copy link
Contributor

@kinow kinow commented Aug 30, 2021

Hi, was reading about it after a friend pointed jupyter-server-proxy. The CONTRIBUTING.md link is not rendered on GitHub UI. Not sure if there's some way to auto link the file in Markdown, or if it was supposed to be a link but just missed the final part?

Thanks!

@welcome
Copy link

welcome bot commented Aug 30, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@manics manics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@manics manics merged commit 9afb9e6 into jupyterhub:master Aug 30, 2021
@welcome
Copy link

welcome bot commented Aug 30, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@kinow kinow deleted the patch-1 branch August 30, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants