Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack config for building prod #7354

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 3, 2024

Copy link
Contributor

github-actions bot commented May 3, 2024

Binder 👈 Launch a Binder on branch jtpio/notebook/webpack-prod

@jtpio
Copy link
Member Author

jtpio commented May 16, 2024

This may also be related to the following issues:

@jtpio
Copy link
Member Author

jtpio commented May 16, 2024

Postponing to 7.3.0, as this likely involves using the html-webpack-plugin to properly inject the script tag with the cache busting hash string. We might also want to take the opportunity to restructure the build so each page has its own app and bundle, similar to the approach taken in JupyterLite:

Instead of the current approach which currently builds a single bundle, and activate a specific list of plugins on each page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant