Recover from failure to render mimetype #6181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 15, 2021
|
This looks good to me! |
minrk
reviewed
Sep 16, 2021
martinRenou
force-pushed
the
recover_from_failure_to_render_mimetype
branch
from
cce6674
to
49d1ad9
Compare
SylvainCorlay
approved these changes
Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easier to review the diff while disabling whitespace diffs: https://github.com/jupyter/notebook/pull/6181/files?diff=split&w=1
This is closer to JupyterLab's behavior.
As an example, if a Jupyter widget fails to render (due to widget state not found), we display other available mimetypes instead of nothing.
This goes in the direction of this PR: matplotlib/ipympl#343 (add support for saving a static version of the matplotlib plot next to the widget mimetype) which works properly in JupyterLab but not in Notebook yet.
PR goes in pair with jupyter-widgets/ipywidgets#3280