Docker build optimizations and miscellaneous fixes #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
changed the title
jakirkham
force-pushed
the
docker_build_optimizations
branch
4 times, most recently
from
733ceeb
to
58cbf8d
Compare
jakirkham
changed the title
jakirkham
changed the title
jakirkham
force-pushed
the
docker_build_optimizations
branch
2 times, most recently
from
b031685
to
194f165
Compare
jakirkham
changed the title
…ppear after `pip` and `npm` steps anyways.
…rectory only contains `bower` stuff and `bower` is removed in this `RUN` step.
…ectory only contains `bower` stuff and `bower` is removed in this `RUN` step.
…and is empty afterwards.
jakirkham
force-pushed
the
docker_build_optimizations
branch
from
194f165
to
7e4aa2a
Compare
|
@jakirkham I'm having trouble tracking your PRs - this seems to just be a merge of several other PRs. Do you mean to close all the others and replace with this one? |
|
Initially this was a PR with most (not all) of these changes. However, I realized I did not want to force your hand into accepting changes that you did not want. So, I broke it up into smaller PRs that you could take or leave and left this one as a combined form that you could take instead. As most of the PRs are already merged, maybe it doesn't make sense to keep this any more. Especially, if it is the source of confusion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some optimizations for the build process.
InsecurePlatformWarnings ( Resolve someInsecurePlatformWarningwhen installing withpip#588 ).Checks out locally. Able to build image and do some basic stuff in the notebook.