Fix setting of cell execution timeout

jupyter · Feb 1, 2023 · c3176fb · c3176fb
1 parent ca7b0e5
commit c3176fb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/nbgrader/preprocessors/execute.py b/nbgrader/preprocessors/execute.py
@@ -17,7 +17,7 @@ class Execute(NbGraderPreprocessor, ExecutePreprocessor):
     interrupt_on_timeout = Bool(True)
     allow_errors = Bool(True)
     raise_on_iopub_timeout = Bool(True)
-    timeout = Integer(30)
+    timeout = Integer(30).tag(config=True)
 
     error_on_timeout = {
         "ename": "CellTimeoutError",

diff --git a/nbgrader/validator.py b/nbgrader/validator.py
@@ -286,11 +286,8 @@ def _preprocess(self, nb: NotebookNode) -> NotebookNode:
         resources = {}
         with utils.setenv(NBGRADER_VALIDATING='1', NBGRADER_EXECUTION='validate'):
             for preprocessor in self.preprocessors:
-                # https://github.com/jupyter/nbgrader/pull/1075
-                # It seemes that without the self.config passed below,
-                # --ExecutePreprocessor.timeout doesn't work.  Better solution
-                # requested, unknown why this is needed.
-                pp = preprocessor(**self.config[preprocessor.__name__])
+                # Let configuration be handled by traitlets
+                pp = preprocessor(parent=self)
                 nb, resources = pp.preprocess(nb, resources)
         return nb