Fix for windows timeout testing errors

jupyter · Mar 29, 2023 · 3e8f778 · 3e8f778
1 parent 0d41a7e
commit 3e8f778
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/nbgrader/tests/apps/test_nbgrader_autograde.py b/nbgrader/tests/apps/test_nbgrader_autograde.py
@@ -1096,7 +1096,8 @@ def test_autograde_timeout(self, db, course_dir):
         self._copy_file(join("files", "timeout.ipynb"), join(course_dir, "submitted", "bar", "ps1", "p1.ipynb"))
 
         output = run_nbgrader(["autograde", "ps1", "--db", db, "--student", "foo"])
-        output = run_nbgrader(["autograde", "ps1", "--db", db, "--student", "bar", "--Execute.timeout=1"])
+        # timeout=2 secs, 1 was causing an asyncio error on Windows
+        output = run_nbgrader(["autograde", "ps1", "--db", db, "--student", "bar", "--Execute.timeout=2"])
 
         # Check timeout config changes function based on timeout config
         with Gradebook(db) as gb:

diff --git a/nbgrader/tests/apps/test_nbgrader_validate.py b/nbgrader/tests/apps/test_nbgrader_validate.py
@@ -139,6 +139,7 @@ def test_validate_timeout(self, db, course_dir):
         output = run_nbgrader(["validate", "nb1.ipynb"], stdout=True)
         assert output.strip() == "Success! Your notebook passes all the tests."
 
-        output = run_nbgrader(["validate", "--Execute.timeout=1", "nb1.ipynb"], stdout=True)
+        # timeout=1 leads to an asyncio error on Windows
+        output = run_nbgrader(["validate", "--Execute.timeout=2", "nb1.ipynb"], stdout=True)
         assert output.splitlines()[-2].strip() == "CellTimeoutError: No reply from kernel before timeout"