Fix version parsing #739
Fix version parsing #739
Conversation
nbdime/_version.py
Outdated
| version_info = VersionInfo( | ||
| int(groups["major"]), | ||
| int(groups["minor"]), | ||
| int(groups["micro"]), | ||
| _specifier_[groups.get("releaselevel", "")], | ||
| _specifier_.get(groups.get("releaselevel", ""), "final"), |
There was a problem hiding this comment.
I'm not sure if this is the right choice: if someone makes a mistake and bumps to "beta" instead of "b", then it will default to final since it cannot parse it?
There was a problem hiding this comment.
Would you mind sharing what error you were seeing that this will fix?
There was a problem hiding this comment.
| _specifier_.get(groups.get("releaselevel", ""), "final"), | |
| _specifier_[groups.get("releaselevel") or ""], |
There was a problem hiding this comment.
The error is that if not found groups.get("releaselevel") is None. Therefore, as None is not a key of _specificer, it raises an KeyError.
I'll go for a more advance solution than Vidar's proposal as the proposed solution does not address the case of release level being beta for example.
There was a problem hiding this comment.
My point was that "beta" would be an invalid value that should throw an error. Somewhere at least.. probably not good for it to throw in packaged code though, so this change is fine. But yes, let's try to get a regression test for the future as well.
There was a problem hiding this comment.
For documentation, beta is a valid specifier: https://peps.python.org/pep-0440/#pre-release-spelling
|
Merging and releasing a patch version |
Follow-up of 4.0.0 release
Xref #659 (comment)