Fix duplicate pickers #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(to have a cleaner diff, exclude the lint commit from the range) |
To avoid remote, local and merge diff views adding overlapping gutter markers of the same type on the same line. We leave it to CM to handle multiple markers of different types on the same line, but that shouldn't really apply for us.
vidartf
force-pushed
the
fix-dup-pickers
branch
from
33a903a
to
2bb9f82
Compare
|
Hmm... The UI tests shouldn't be passing without a rerender, since the bug is in one of the UI tests, so something went wrong here.. |
Use simple identity comparison.
|
Bot please update playwright snapshots |
|
Playwright ubuntu-22.04 snapshots updated. |
|
Playwright windows-latest snapshots updated. |
krassowski
reviewed
Nov 10, 2023
|
Bot please update playwright snapshots |
|
Playwright windows-latest snapshots updated. |
|
Playwright ubuntu-22.04 snapshots updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid remote, local and merge diff views adding overlapping gutter markers of the same type on the same line. We leave it to CM to handle multiple markers of different types on the same line, but that shouldn't really apply for us.
Fixes #700 .