Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a devcontainer #637

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
2 changes: 1 addition & 1 deletion .devcontainer/scripts/setup.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

pip install .
pip install -e .
python setup.py build

# sudo mkdir /usr/local/share/jupyter
Expand Down
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,7 @@ The python setup.py script will built the entirety of the project and place it i
### Running npm tests

The project uses jest to test the javascript, a typescript compile step occurs before the test suite runs. You can run the tests for the entire project with `npm run test` in the root, or change directories to the package you are working on and run `npm run test` to test just that package.

### VSCode/CodeSpace Setup

If you are working in vscode with GitHub codespaces many of the command you will need to run have been moved into vscode tasks. This includes building the webapp and lab extension, running test, launching the webapp, launching vscode and others. You can see the available tasks by choosing `Run Build Task from the global Terminal menu` to learn more about tasks see [this doc](https://code.visualstudio.com/docs/editor/tasks).
1 change: 1 addition & 0 deletions packages/webapp/src/app/diff.ts
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ function initializeDiff() {
compare(base, remote, 'replace');
}

console.log("RUns")
vidartf marked this conversation as resolved.
Show resolved Hide resolved
let exportBtn = document.getElementById('nbdime-export') as HTMLButtonElement;
exportBtn.onclick = exportDiff;

Expand Down
5 changes: 0 additions & 5 deletions scripts/rebuild-lab.sh

This file was deleted.

4 changes: 0 additions & 4 deletions scripts/watch-lab.sh

This file was deleted.

4 changes: 0 additions & 4 deletions scripts/watch-webapp.sh

This file was deleted.