- changing mermaid suport #2120
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 2, 2024
Merged
bollwyvl
reviewed
Mar 3, 2024
for more information, see https://pre-commit.ci
bollwyvl
reviewed
Mar 4, 2024
share/templates/reveal/index.html.j2
Outdated
| ], | ||
|
|
||
| function(Reveal, RevealNotes){ | ||
| function(Reveal, RevealNotes, RevealMermaid){ |
There was a problem hiding this comment.
sorry, missed this: the positional argument would need to be conditional as well:
function(
Reveal,
RevealNotes,
{% if reveal_mermaid_js_url %}RevealMermaid,{% endif %}
){Also feel free to normalize the whitespace: the "floating indent" style isn't necessary, just consistency with what's around (in this case four spaces).
There was a problem hiding this comment.
good idea, i also did that...
There was a problem hiding this comment.
Can someone please assign the improvement label? I am sorry, i either don't have the right to set it, or i just don't find the feature...
bollwyvl
reviewed
Mar 5, 2024
share/templates/reveal/index.html.j2
Outdated
| @@ -145,21 +143,26 @@ require( | |||
| }, | |||
| [ | |||
| "{{ reveal_url_prefix }}/dist/reveal.js", | |||
| "{{ reveal_url_prefix }}/plugin/notes/notes.js" | |||
| "{{ reveal_url_prefix }}/plugin/notes/notes.js", | |||
| {% if reveal_mermaid_js_url %}"{{ reveal_mermaid_js_url }}",{% endif %}, | |||
There was a problem hiding this comment.
there's an extra comma after the endif
bollwyvl
reviewed
Mar 5, 2024
|
@bollwyvl .: Is there still something I need to do? Something i overlooked? Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the already existing mermaid support, did not work for me.
It showed me "syntax error bomb displays", which where displayed just milliseconds after the correctly rendered graph was shown.
I added the reveal mermaid plugin, and removed the already existing mermaid initialisation.
While this does work for me, it is probably quite a change and i really would like to get some input on how to continue, or change my environment to fit the preexisting solution (which is still used for the hard parts, i basically swap pure mermaid for the plugin, as a result of trial and error)