Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for section (slide) "data-*" attributes #1861

Merged
merged 6 commits into from Sep 12, 2022

Conversation

bouzidanas
Copy link
Contributor

@bouzidanas bouzidanas commented Sep 7, 2022

Feature: Add <section> tag metadata ( data-* ) attributes by adding a new notebook cell metadata attribute called "data" inside the slideshow attribute:

{
    "id": "QhrtDbohUhIF",
    "slideshow": {
        "slide_type": "slide",
        "data": {
          "background_video": "video_url.mp4",
          "background_video_loop": "",
          "background_video_muted": ""
        }
    }
}

@bouzidanas bouzidanas changed the title Working added ability to set slide "data-*" attribute Sep 8, 2022
@bouzidanas bouzidanas changed the title added ability to set slide "data-*" attribute added ability to set slide/section "data-*" attributes Sep 8, 2022
@bouzidanas bouzidanas changed the title added ability to set slide/section "data-*" attributes Added ability to set slide/section "data-*" attributes Sep 8, 2022
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@blink1073 blink1073 merged commit e618f91 into jupyter:main Sep 12, 2022
@bouzidanas bouzidanas changed the title Added ability to set slide/section "data-*" attributes Added support for section (slide) "data-*" attributes Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants