Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Mistune v3 #1820

Merged
merged 9 commits into from
Jun 16, 2023
Merged

Update to Mistune v3 #1820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
852a005
Bump Mistune to v3
TiagodePAlves Jun 16, 2023
86bc639
Update MarkdownWithMath for Mistune v3
TiagodePAlves Jun 16, 2023
0dd7c94
Update MathBlockParser for Mistune v3
TiagodePAlves Jun 16, 2023
7af4606
Accept headings without leading spaces in markdown2html
TiagodePAlves Jun 16, 2023
743eb0a
Update MathInlineParser for Mistune v3
TiagodePAlves Jun 16, 2023
7b594c2
Update IPythonRenderer for Mistune v3
TiagodePAlves Jun 16, 2023
8aa1a9b
Add more type hints for markdown2html_mistune
TiagodePAlves Jun 16, 2023
be2990e
Fix types in markdown_mistune.py for Python 3.7
TiagodePAlves Jun 16, 2023
1b36901
Enable compatibility with Mistune v2
TiagodePAlves Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions nbconvert/filters/markdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,14 @@

try:
from .markdown_mistune import markdown2html_mistune

except ImportError as e:
# store in variable for Python 3
_mistune_import_error = e

def markdown2html_mistune(source):
def markdown2html_mistune(source: str) -> str:
"""mistune is unavailable, raise ImportError"""
raise ImportError("markdown2html requires mistune: %s" % _mistune_import_error)
msg = f"markdown2html requires mistune: {_mistune_import_error}"
raise ImportError(msg)


from .pandoc import convert_pandoc
Expand Down