Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an invalid notebook error #1675

Merged
merged 2 commits into from Dec 10, 2021
Merged

Add an invalid notebook error #1675

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fed11e6
Add an invalid notebook error
gwincr11 Nov 18, 2021
493aa18
Update nbconvert/filters/markdown_mistune.py
gwincr11 Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion nbconvert/filters/markdown_mistune.py
View file
Open in desktop
Expand Up @@ -160,7 +160,10 @@ def image(self, src, title, text):
attachment_prefix = 'attachment:'
if src.startswith(attachment_prefix):
name = src[len(attachment_prefix):]
assert name in attachments, "missing attachment: {}".format(name)

if not name in attachments:
nbconvert.InvalidNotebook.new("missing attachment: {}".format(name))
gwincr11 marked this conversation as resolved.
Show resolved Hide resolved

attachment = attachments[name]
# we choose vector over raster, and lossless over lossy
preferred_mime_types = ['image/svg+xml', 'image/png', 'image/jpeg']
Expand Down
3 changes: 3 additions & 0 deletions nbconvert/nbconvertapp.py
View file
Open in desktop
Expand Up @@ -595,6 +595,9 @@ def initialize(self, argv=None):
def default_export_format(self):
return 'html'

class InvalidNotebook(Exception):
pass

#-----------------------------------------------------------------------------
# Main entry point
#-----------------------------------------------------------------------------
Expand Down