Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to detect if we are in a virtual environment and change path precedence accordingly #286

Merged
merged 8 commits into from Aug 24, 2022
Merged

Try to detect if we are in a virtual environment and change path precedence accordingly #286

merged 8 commits into from Aug 24, 2022

Commits on Aug 22, 2022

  1. Try to detect if we are in a virtual environment and change path prec… 

    …edence accordingly.

We make the assumption that if we are in a virtual environment, we should prioritize the environment-level sys.prefix over the user-level paths. The user can opt out of this behavior by setting JUPYTER_PREFER_ENV_PATH, which takes precedence over our autodetection.

Fixes jupyter#283
    @jasongrout
    jasongrout committed Aug 22, 2022
    Copy the full SHA
    80a29cd View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 22, 2022
    Copy the full SHA
    8a4839d View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Test new arguments to envset

    @jasongrout
    jasongrout committed Aug 24, 2022
    Copy the full SHA
    21d860f View commit details
    Browse the repository at this point in the history

  2. Be more explicit about the JUPYTER_PREFER_ENV_PATH setting when it ma… 

    …tters.

Now that we have autodetection logic for when we are in a virtual env, we must explicitly set this variable to off if we expect it off.
    @jasongrout
    jasongrout committed Aug 24, 2022
    Copy the full SHA
    6b96a71 View commit details
    Browse the repository at this point in the history

  3. Fix typo in path calculation code

    @jasongrout
    jasongrout committed Aug 24, 2022
    Copy the full SHA
    8b5f1c5 View commit details
    Browse the repository at this point in the history

  4. Fix command tests by adjusting language for debug switch

    @jasongrout
    jasongrout committed Aug 24, 2022
    Copy the full SHA
    def0a25 View commit details
    Browse the repository at this point in the history

  5. Test prefer_environment_over_user utility function.

    @jasongrout
    jasongrout committed Aug 24, 2022
    Copy the full SHA
    7cbab21 View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 24, 2022
    Copy the full SHA
    9e21f27 View commit details
    Browse the repository at this point in the history