Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up pre-commit #255

Merged
merged 4 commits into from Apr 7, 2022
Merged

Set up pre-commit #255

merged 4 commits into from Apr 7, 2022

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Apr 7, 2022

Copies pre-commit config from jupyter_server
Runs auto-formatters
Adds git-blame-ignore-revs file.

This should be merged without a squash so the git-blame-ignore-revs file works.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Since I always have to refresh my memory on crontab formats, I just left the one (non-essential) comment.
Thanks for making the build infrastructures consistent throughout!

.github/workflows/codeql-analysis.yml Show resolved Hide resolved
Co-authored-by: Kevin Bates <kbates4@gmail.com>
@blink1073
Copy link
Member Author

GitHub says it is fully operational but page loads and actions are definitely degraded

@blink1073 blink1073 merged commit 6efee94 into jupyter:master Apr 7, 2022
@blink1073 blink1073 deleted the use-precommit branch April 7, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants