Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Python to 3.11 #1812

Closed
wants to merge 0 commits into from
Closed

Upgrade Python to 3.11 #1812

wants to merge 0 commits into from

Conversation

bjornjorgensen
Copy link
Contributor

@bjornjorgensen bjornjorgensen commented Oct 25, 2022

Describe your changes

Upgrade PYTHON_VERSION from 3.10 to 3.11

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@benz0li
Copy link
Contributor

benz0li commented Oct 25, 2022

Regarding scipy-notebook:

  • numba does not yet support Python 3.11.
  • The current release of pytables and statsmodels do not support Python 3.11.
    • Both packages build from branch main, though.

Cross references:

@mathbunnyru
Copy link
Member

Please, also change the python version in tests.

@bjornjorgensen
Copy link
Contributor Author

Thank you @benz0li and @mathbunnyru
I found one test that I have changed the python version to 3.11

@bjornjorgensen
Copy link
Contributor Author

bjornjorgensen commented Oct 25, 2022

hmmm... it failed with some strange errors

#14 12.04 Encountered problems while solving:
#14 12.04   - package mamba-0.18.1-py310hcf12e44_1 requires python_abi 3.10.* *_cp310, but none of the providers can be installed


#15 24.31 error    libmamba Could not solve for environment specs
#15 24.31 Encountered problems while solving:
#15 24.31   - package mamba-0.0.10-py27hc9558a2_1 requires python >=2.7,<2.8.0a0, but none of the providers can be installed

But where does this old mamba come from?

@mathbunnyru
Copy link
Member

I think micromamba is installing an old version of mamba when there are no good versions.
I beleive it's too early to start using python-3.11 in our project because we have to wait for all the dependencies to support it.

Currently, we don't have any policy on when to update the python version.
Guess a reasonable one would be to wait for both:

  • all the dependencies to be available
  • the first python patch release, for example, python-3.11.1 (this is to avoid many bugs, which can happen in a major release)

@bjornjorgensen
Copy link
Contributor Author

@mathbunnyru Yes, that it a good idea.

@bjornjorgensen bjornjorgensen changed the title Upgrade PYTHON_VERSION to 3.11 Upgrade Python to 3.11 Oct 26, 2022
@mathbunnyru mathbunnyru marked this pull request as draft October 26, 2022 12:19
@mathbunnyru
Copy link
Member

I've converted this to a draft, because it's unlikely we will merge this really soon. I think we can try to close/reopen this PR in a month or so to make sure our images build fine.

@EwoutH
Copy link

EwoutH commented Nov 1, 2022

Statsmodels 0.13.3 is released, with Python 3.11 wheels!

@bjornjorgensen
Copy link
Contributor Author

@EwoutH yes, but When should you upgrade to Python 3.11? so will wait for 3.11.1 and everything else that we have are supported in python 3.11

@bjornjorgensen
Copy link
Contributor Author

#1815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants