Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run black pre-commit on python code in docs #1661

Merged
merged 5 commits into from Mar 18, 2022

Conversation

mathbunnyru
Copy link
Member

@mathbunnyru mathbunnyru commented Mar 17, 2022

It would be nice if people could copy our code from the documentation and paste it into their projects and it would work without any changes.
This also makes the code in the docs follow the same principles as we have in our main projects.
It also makes the review process easier - because the docs are easier to read.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but if possible, we should stick with python syntax highlighting even when its a jupyter magic involved.

.pre-commit-config.yaml Show resolved Hide resolved
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
@mathbunnyru mathbunnyru merged commit 6226ae0 into jupyter:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants