Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using _comm_default shadows possible bugs #3590

Merged

Conversation

maartenbreddels
Copy link
Member

This came up when working on ipython/traitlets#777, instead of _comm_default, this method seems to trigger more code paths, which revealed that we couldn't create the DataWidget (since the default was None because we didn't pass in args=()).

@jasongrout
Copy link
Member

Thanks!

@jasongrout jasongrout merged commit 892166d into jupyter-widgets:7.x Sep 15, 2022
@maartenbreddels
Copy link
Member Author

@meeseeksdev please backport to master

@lumberbot-app
Copy link

lumberbot-app bot commented Sep 15, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout master
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 892166dd0524e93b912d8826a6da26c09afd4366
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #3590: fix: using _comm_default shadows possible bugs'
  1. Push to a named branch:
git push YOURFORK master:auto-backport-of-pr-3590-on-master
  1. Create a PR against branch master, I would have named this PR:

"Backport PR #3590 on branch master (fix: using _comm_default shadows possible bugs)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

maartenbreddels pushed a commit to maartenbreddels/ipywidgets that referenced this pull request Sep 15, 2022
jasongrout added a commit that referenced this pull request Sep 16, 2022
…cated_8_port

Backport PR #3590: using _comm_default shadows possible bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants