Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagsInput widget #2591

Merged
merged 1 commit into from May 12, 2020
Merged

TagsInput widget #2591

merged 1 commit into from May 12, 2020

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Oct 21, 2019 •
edited

tagsinput

@martinRenou martinRenou changed the title WIP - TagsInput widget TagsInput widget Oct 25, 2019
@vidartf
Copy link
Member

vidartf commented Oct 28, 2019

This looks like an interesting widget, but it isn't obvious to me if this belongs in controls or in a third-party package. Do we have a policy here?

@martinRenou
Copy link
Member Author

There is more in https://github.com/martinRenou/tagsinput. I can update this PR if needed

@martinRenou
Copy link
Member Author

This looks like an interesting widget, but it isn't obvious to me if this belongs in controls or in a third-party package. Do we have a policy here?

I don't know myself, and I guess it will be the same question for the TextSlider PR. Maybe @jasongrout @SylvainCorlay you can answer this?

@SylvainCorlay
Copy link
Member

Vidar: Neutral for inclusion
Jason: Neutral
Sylvain: Slightly in favor (don't see a better place for it).

Line of divide for inclusion?

  • browser standard control -> yes
  • "very common UX control" ?

@pbugnion pbugnion mentioned this pull request Jan 8, 2020
Closed
@jasongrout jasongrout added this to the 8.0 milestone Jan 17, 2020
@Alexboiboi
Copy link

Hi there,

thanks @martinRenou, I really like the widget and I am looking forward to see it in the main package!
@jasongrout, any chance this is going to be merged soon?

@SylvainCorlay
Copy link
Member

@martinRenou, could you rebase this one? We decided to go ahead with this PR.

@SylvainCorlay SylvainCorlay force-pushed the badges branch 2 times, most recently from 0eb6716 to cc4e607 Compare May 12, 2020 09:43
@SylvainCorlay SylvainCorlay force-pushed the badges branch 2 times, most recently from 897999a to 9c43db1 Compare May 12, 2020 10:14
@martinRenou @SylvainCorlay
Add TagsInput widget
250d471 
Signed-off-by: martinRenou <martin.renou@gmail.com>
@SylvainCorlay SylvainCorlay merged commit 9090b44 into jupyter-widgets:master May 12, 2020
@martinRenou martinRenou deleted the badges branch May 12, 2020 11:37
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jun 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SylvainCorlay SylvainCorlay SylvainCorlay left review comments

Assignees
No one assigned
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@martinRenou @vidartf @SylvainCorlay @Alexboiboi @jasongrout