Merge pull request #3625 from martinRenou/soften_manager_requirement

WidgetRenderer: Soften manager type requirement
jupyter-widgets · Nov 6, 2022 · c5103e4 · c5103e4
2 parents 31ee8c8 + 5d9f503
commit c5103e4
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/python/jupyterlab_widgets/src/renderer.ts b/python/jupyterlab_widgets/src/renderer.ts
@@ -9,7 +9,7 @@ import { Panel, Widget as LuminoWidget } from '@lumino/widgets';
 
 import { IRenderMime } from '@jupyterlab/rendermime-interfaces';
 
-import { WidgetManager } from './manager';
+import { LabWidgetManager } from './manager';
 import { DOMWidgetModel } from '@jupyter-widgets/base';
 
 /**
@@ -19,7 +19,10 @@ export class WidgetRenderer
   extends Panel
   implements IRenderMime.IRenderer, IDisposable
 {
-  constructor(options: IRenderMime.IRendererOptions, manager?: WidgetManager) {
+  constructor(
+    options: IRenderMime.IRendererOptions,
+    manager?: LabWidgetManager
+  ) {
     super();
     this.mimeType = options.mimeType;
     if (manager) {
@@ -30,7 +33,7 @@ export class WidgetRenderer
   /**
    * The widget manager.
    */
-  set manager(value: WidgetManager) {
+  set manager(value: LabWidgetManager) {
     value.restored.connect(this._rerender, this);
     this._manager.resolve(value);
   }
@@ -117,6 +120,6 @@ export class WidgetRenderer
    * The mimetype being rendered.
    */
   readonly mimeType: string;
-  private _manager = new PromiseDelegate<WidgetManager>();
+  private _manager = new PromiseDelegate<LabWidgetManager>();
   private _rerenderMimeModel: IRenderMime.IMimeModel | null = null;
 }