Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix examples/KML.ipynb to work with recent versions of geopandas #1141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rdhyee
Copy link

@rdhyee rdhyee commented Oct 27, 2023

examples/KML.ipynb is broken in v 0.17.4 of ipyleaflet -- you can verify this problem by running the notebook in mybinder.org and see the following error:

image

I implemented a fix based on the discussion at geopandas - AttributeError: 'NoneType' object has no attribute 'drvsupport' when using Fiona driver - Stack Overflow.

You can also see how this PR fixes the problem by running the notebook in this branch on mybinder.org:

image

…ona dynamically, and gpd.io.file.fiona is initially None.
@rdhyee
Copy link
Author

rdhyee commented Oct 27, 2023

Curious whether the document build failure is related to the changes in how Stamen is hosting its tiles.

@martinRenou
Copy link
Member

Triggering CI

@martinRenou martinRenou reopened this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants