Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename JS package to @jupyter/ydoc #97

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 25, 2022

Follow-up to #86

This was discussed elsewhere on the JupyterLab repo.

Now that some of us managed to get a hold on the @jupyter scope on npm, it could interesting to rename this package to @jupyter/ydoc for consistency and early enough before it gets used more downstream.

cc @fcollonval

@jtpio jtpio closed this Nov 29, 2022
@jtpio jtpio reopened this Nov 29, 2022
@fcollonval fcollonval merged commit 4b0111f into jupyter-server:main Nov 29, 2022
@fcollonval
Copy link
Member

@meeseeksdev please backport to 0.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 29, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.2.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 4b0111f731abca3bc5ad4bd0cff57fcf2cdde2ed
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #97: Rename JS package to `@jupyter/ydoc`'
  1. Push to a named branch:
git push YOURFORK 0.2.x:auto-backport-of-pr-97-on-0.2.x
  1. Create a PR against branch 0.2.x, I would have named this PR:

"Backport PR #97 on branch 0.2.x (Rename JS package to @jupyter/ydoc)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval pushed a commit to fcollonval/jupyter_ydoc that referenced this pull request Nov 29, 2022
fcollonval added a commit that referenced this pull request Nov 29, 2022
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@jtpio jtpio deleted the rename-js-package branch November 29, 2022 08:46
@jtpio
Copy link
Member Author

jtpio commented Nov 29, 2022

Opened jupyterlab/jupyterlab#13506 as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants