Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #826 on branch 1.x (Defer preferred_dir validation until root_dir is set) #828

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #826: Defer preferred_dir validation until root_dir is set

@lumberbot-app lumberbot-app bot added the bug label May 3, 2022
@echarles echarles mentioned this pull request May 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #828 (6b219cf) into 1.x (2e31f90) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              1.x     #828      +/-   ##
==========================================
- Coverage   70.47%   70.45%   -0.03%     
==========================================
  Files          62       62              
  Lines        7540     7554      +14     
  Branches     1250     1255       +5     
==========================================
+ Hits         5314     5322       +8     
- Misses       1843     1851       +8     
+ Partials      383      381       -2     
Impacted Files Coverage Δ
jupyter_server/pytest_plugin.py 88.42% <100.00%> (+0.10%) ⬆️
jupyter_server/serverapp.py 65.68% <100.00%> (+0.38%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 78.64% <0.00%> (-1.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e31f90...6b219cf. Read the comment docs.

@blink1073 blink1073 merged commit 999b056 into jupyter-server:1.x May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants