Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to flit #823

Merged
merged 7 commits into from May 2, 2022
Merged

Switch to flit #823

merged 7 commits into from May 2, 2022

Conversation

blink1073
Copy link
Collaborator

@blink1073 blink1073 commented May 1, 2022

Fixes #796

Used ini2toml to do the heavy lifting.

Depends on jupyter-server/jupyter_releaser#308 for a fix to nested resource paths checking.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #823 (f11e6e5) into main (6d84507) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head f11e6e5 differs from pull request most recent head 41a94c5. Consider uploading reports for the commit 41a94c5 to get more accurate results

@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
+ Coverage   70.20%   70.24%   +0.04%     
==========================================
  Files          63       63              
  Lines        7480     7480              
  Branches     1253     1253              
==========================================
+ Hits         5251     5254       +3     
+ Misses       1849     1843       -6     
- Partials      380      383       +3     
Impacted Files Coverage Δ
jupyter_server/services/kernels/kernelmanager.py 80.58% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5164e2...41a94c5. Read the comment docs.

@blink1073 blink1073 marked this pull request as ready for review May 2, 2022 21:09
@Zsailer
Copy link
Member

Zsailer commented May 2, 2022

Wow, this is beautiful! Moving everything from setup.py and setup.cfg into the single file, pyproject.toml, so so clean. Also, the way flit handles the dynamic version is nice. The whole thing is quite readable. Thank you, @blink1073, for doing this clean up.

This looks good to me. Is this ready to go?

@blink1073 blink1073 merged commit 196ee87 into jupyter-server:main May 2, 2022
@blink1073 blink1073 deleted the verify-assets branch May 2, 2022 21:26
@blink1073
Copy link
Collaborator Author

Yup. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to Flit Packaging Backend
3 participants