Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused pytest-mock dependency #814

Merged
merged 1 commit into from Apr 28, 2022
Merged

Remove unused pytest-mock dependency #814

merged 1 commit into from Apr 28, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Apr 28, 2022

Remove the dependency on pytest-mock, as the mocker fixture is not
used anywhere in the source code, and all tests pass without it.

@mgorny
Remove unused pytest-mock dependency
0fe2646 
Remove the dependency on pytest-mock, as the `mocker` fixture is not
used anywhere in the source code, and all tests pass without it.
blink1073
blink1073 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 73a03a6 into jupyter-server:main Apr 28, 2022
@mgorny
Copy link
Contributor Author

mgorny commented Apr 28, 2022

Thank you for merging both my PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgorny @blink1073 @minrk