Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the root_dir value to the logging message in case of non compliant preferred_dir #804

Merged
merged 4 commits into from Apr 26, 2022
Merged

Add the root_dir value to the logging message in case of non compliant preferred_dir #804

merged 4 commits into from Apr 26, 2022

Conversation

echarles
Copy link
Member

Fixes #803

@echarles echarles changed the title Add the root_dir value to the logging message in case of non complian… Add the root_dir value to the logging message in case of non compliant preferred_dir Apr 26, 2022
@blink1073
Copy link
Collaborator

It looks like a couple tests need to be updated with the new text.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022 •
edited

Codecov Report

Merging #804 (27384e1) into main (f7f49fa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #804   +/-   ##
=======================================
  Coverage   69.96%   69.96%           
=======================================
  Files          62       62           
  Lines        7368     7368           
  Branches     1223     1223           
=======================================
  Hits         5155     5155           
  Misses       1841     1841           
  Partials      372      372
Impacted Files Coverage Δ
jupyter_server/serverapp.py 65.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f49fa...27384e1. Read the comment docs.

@echarles
Copy link
Member Author

@blink1073 Thx for the review. CI is now green (except 1 failure not relevant to this PR).

blink1073
blink1073 approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit c51f5a8 into jupyter-server:main Apr 26, 2022
@echarles
Copy link
Member Author

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter_server that referenced this pull request Apr 26, 2022
@echarles @meeseeksmachine
Backport PR jupyter-server#804: Add the root_dir value to the logging…
9c08252 
… message in case of non compliant preferred_dir
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 26, 2022
Merged
@echarles
Copy link
Member Author

Thx @blink1073

The backport PR is #804

blink1073 pushed a commit that referenced this pull request Apr 26, 2022
@meeseeksmachine @echarles
Backport PR #804 on branch 1.x (Add the root_dir value to the logging…
1f5f64b 
… message in case of non compliant preferred_dir) (#805)

Co-authored-by: Eric Charles <eric@datalayer.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better logging in case of non compliant preferred_dir
3 participants
@echarles @blink1073 @codecov-commenter