Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing warning when no authorizer in found ZMQ handlers #744

Merged
merged 2 commits into from Mar 16, 2022

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Mar 16, 2022

Looks like I missed one more place where a warning is needed when no authorizer is set.

Fixes #737 (hopefully completely).

@Zsailer Zsailer added the bug label Mar 16, 2022
@Zsailer Zsailer self-assigned this Mar 16, 2022
@blink1073
Copy link
Collaborator

"Update - GitHub Actions is experiencing degraded performance. We are still investigating and will provide an update when we have one."

https://www.githubstatus.com/

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a candidate as well?

if not self.authorizer.is_authorized(self, user, "execute", self.auth_resource):

@Zsailer
Copy link
Member Author

Zsailer commented Mar 16, 2022

good catch, @kevin-bates! Fixed!

@blink1073
Copy link
Collaborator

Let's hold off on trying to do any merging/releasing until GitHub is back in good shape.

@blink1073 blink1073 merged commit 6c58a0e into jupyter-server:main Mar 16, 2022
@Zsailer Zsailer deleted the no-authorizer-2 branch January 16, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.15 series doesn't work with voila standalone server
3 participants