Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI Cleanup #742

Merged
merged 2 commits into from Mar 16, 2022
Merged

More CI Cleanup #742

merged 2 commits into from Mar 16, 2022

Conversation

blink1073
Copy link
Collaborator

  • Adopt more flake8 rules, modeled after what the pip repo uses
  • Enforce a minimum code coverage

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #742 (a9ce005) into main (7f2863f) will increase coverage by 0.07%.
The diff coverage is 39.47%.

@@            Coverage Diff             @@
##             main     #742      +/-   ##
==========================================
+ Coverage   70.56%   70.64%   +0.07%     
==========================================
  Files          62       62              
  Lines        7607     7606       -1     
  Branches     1215     1214       -1     
==========================================
+ Hits         5368     5373       +5     
+ Misses       1873     1865       -8     
- Partials      366      368       +2     
Impacted Files Coverage Δ
jupyter_server/auth/login.py 68.93% <0.00%> (ø)
jupyter_server/auth/logout.py 44.44% <0.00%> (ø)
jupyter_server/auth/security.py 76.31% <0.00%> (ø)
jupyter_server/base/handlers.py 65.72% <0.00%> (ø)
jupyter_server/extension/manager.py 93.89% <ø> (ø)
jupyter_server/extension/serverextension.py 75.86% <0.00%> (ø)
jupyter_server/i18n/__init__.py 43.63% <0.00%> (ø)
jupyter_server/nbconvert/handlers.py 28.57% <0.00%> (ø)
jupyter_server/services/contents/filemanager.py 73.27% <ø> (ø)
jupyter_server/services/contents/manager.py 82.19% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2863f...a9ce005. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants