Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sdist test #736

Merged
merged 6 commits into from Mar 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/python-linux.yml
Expand Up @@ -144,7 +144,7 @@ jobs:
mkdir test
tar --strip-components=1 -zxvf jupyter_server* -C ./test
cd test
pip install -e .[test]
pip install .[test]
pip install pytest-github-actions-annotate-failures
- name: Run Test
run: |
Expand Down
2 changes: 1 addition & 1 deletion jupyter_server/log.py
Expand Up @@ -52,7 +52,7 @@ def log_request(handler):
if status >= 500 and status != 502:
# Log a subset of the headers if it caused an error.
headers = {}
for header in ['Host', 'Accept', 'Referer', 'User-Agent']:
for header in ["Host", "Accept", "Referer", "User-Agent"]:
if header in request.headers:
headers[header] = request.headers[header]
log_method(json.dumps(headers, indent=2))
Expand Down
6 changes: 4 additions & 2 deletions tests/extension/test_launch.py
Expand Up @@ -57,17 +57,19 @@ def _kill_extension_app():
if add_token:
f'--ServerApp.token="{token}"',

root = Path(HERE).parent.parent

process = subprocess.Popen(
[
sys.executable,
"-m",
"mockextensions.app",
"tests.extension.mockextensions.app",
f"--port={port}",
"--ip=127.0.0.1",
"--no-browser",
*argv,
],
cwd=HERE,
cwd=str(root),
)

request.addfinalizer(_kill_extension_app)
Expand Down