Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Re-use ServerApp.config_file_paths for consistency (#715)" #728

Merged
merged 1 commit into from Mar 14, 2022
Merged

Revert "Re-use ServerApp.config_file_paths for consistency (#715)" #728

merged 1 commit into from Mar 14, 2022

Conversation

blink1073
Copy link
Collaborator

This reverts commit 653740c.

Fixes #727

@blink1073 blink1073 added the bug label Mar 14, 2022
@blink1073 blink1073 merged commit 262cb46 into jupyter-server:main Mar 14, 2022
@blink1073 blink1073 deleted the revert-config-pr branch March 14, 2022 11:59
@davidbrochart
Copy link
Contributor

I don't see how it could be related to this PR, but since I updated to jupyter-server v1.15.2 in jupyterlab/jupyterlab#11599, I get this error:

jupyter labextension link . --no-build
An error occurred.
traitlets.config.configurable.MultipleInstanceError: An incompatible sibling of 'ServerApp' is already instanciated as singleton: LinkLabExtensionApp

@blink1073
Copy link
Collaborator Author

It is failing in recent jupyterlab tests as well, reverting again.

@minrk
Copy link
Contributor

minrk commented Mar 14, 2022

Arg, it is related. Caused by #730. Fix shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server Release 1.15.0 is Broken
3 participants
@blink1073 @davidbrochart @minrk