Fix notebook URL opened in browser when redirect file not used #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
|
If this PR is on the right track, I can try adding some tests. Lmk. |
With `notebook~=7.0` ServerApp is responsible for launching browser, not NotebookApp anymore. In `notebook~=6.0`, `launch_browser` will append notebook path for opening in browser even when `use_redirect_file` is set to `false` - unlike ServerApp, ever since 60c66b6.
randomir
force-pushed
the
fix/notebook-open-in-browser-without-redirect-file/issue-1325
branch
from
00447c1
to
3083173
Compare
|
@Zsailer, thanks for taking a look. I can take a crack at writing a test, and then ping you when I think it's ready for review. |
|
Great! thanks @randomir! Let me know if you need any help or have any questions around our unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1325.
With
notebook~=7.0ServerApp is responsible for launching browser, not NotebookApp anymore. Innotebook~=6.0,launch_browserwill append notebook path for opening in browser even whenuse_redirect_fileis set tofalse.ServerApp used to do the same, last time in v1.3.0. The change in behavior/bug seems to be introduced in 1bbcbcb359, released as 1.4.0.