Skip to content

Commit

Permalink
Fix sdist test (#736)
Browse files Browse the repository at this point in the history
  • Loading branch information
blink1073 committed Mar 15, 2022
1 parent 2d01be6 commit 66ef12d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/python-linux.yml
Expand Up @@ -144,7 +144,7 @@ jobs:
mkdir test
tar --strip-components=1 -zxvf jupyter_server* -C ./test
cd test
pip install -e .[test]
pip install .[test]
pip install pytest-github-actions-annotate-failures
- name: Run Test
run: |
Expand Down
2 changes: 1 addition & 1 deletion jupyter_server/log.py
Expand Up @@ -52,7 +52,7 @@ def log_request(handler):
if status >= 500 and status != 502:
# Log a subset of the headers if it caused an error.
headers = {}
for header in ['Host', 'Accept', 'Referer', 'User-Agent']:
for header in ["Host", "Accept", "Referer", "User-Agent"]:
if header in request.headers:
headers[header] = request.headers[header]
log_method(json.dumps(headers, indent=2))
Expand Down
6 changes: 4 additions & 2 deletions tests/extension/test_launch.py
Expand Up @@ -57,17 +57,19 @@ def _kill_extension_app():
if add_token:
f'--ServerApp.token="{token}"',

root = Path(HERE).parent.parent

process = subprocess.Popen(
[
sys.executable,
"-m",
"mockextensions.app",
"tests.extension.mockextensions.app",
f"--port={port}",
"--ip=127.0.0.1",
"--no-browser",
*argv,
],
cwd=HERE,
cwd=str(root),
)

request.addfinalizer(_kill_extension_app)
Expand Down

0 comments on commit 66ef12d

Please sign in to comment.