Fix variable name for GitHub output #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 81.16% // Head: 81.16% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 20 20
Lines 2824 2824
Branches 365 365
=======================================
Hits 2292 2292
Misses 399 399
Partials 133 133
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jtpio
reviewed
Oct 19, 2022
| if "GITHUB_ENV" in os.environ: | ||
| with open("GITHUB_ENV", "a") as fid: | ||
| if "GITHUB_OUTPUT" in os.environ: | ||
| with open("GITHUB_OUTPUT", "a") as fid: |
There was a problem hiding this comment.
Should GITHUB_OUTPUT be a file, or an environment variable?
There was a problem hiding this comment.
Hitting this issue: jupyter/notebook#6579 (comment)
Maybe it should be something like the following:
Suggested change
| with open("GITHUB_OUTPUT", "a") as fid: | |
| with open(os.environ["GITHUB_OUTPUT"], "a") as fid: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.