Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of git actor #424

Merged
merged 7 commits into from Oct 6, 2022
Merged

Conversation

blink1073
Copy link
Contributor

  • Use the current actor set set the git user
  • Ensure the authenticated user has admin permissions to run the actions

Fixes #423

@blink1073 blink1073 added the enhancement New feature or request label Oct 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 81.59% // Head: 81.30% // Decreases project coverage by -0.28% ⚠️

Coverage data is based on head (536a0cf) compared to base (593f261).
Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   81.59%   81.30%   -0.29%     
==========================================
  Files          20       20              
  Lines        2776     2782       +6     
  Branches      358      360       +2     
==========================================
- Hits         2265     2262       -3     
- Misses        385      392       +7     
- Partials      126      128       +2     
Impacted Files Coverage Δ
jupyter_releaser/tests/test_cli.py 98.85% <ø> (ø)
jupyter_releaser/util.py 71.12% <0.00%> (-0.78%) ⬇️
jupyter_releaser/lib.py 77.71% <28.57%> (-1.15%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073
Copy link
Contributor Author

@blink1073 blink1073 merged commit 8a8cc1a into jupyter-server:main Oct 6, 2022
@blink1073 blink1073 deleted the ensure-admin branch October 6, 2022 15:39
blink1073 added a commit that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Handling for Simplified Workflow
2 participants