Add sql-language-server #326
Conversation
|
Speaking of node, it seems that docs do not like the version bump of jest: |
|
And installation notebook is outdated saying that Node >= 8 is fine. |
|
Jest has a weird dependency update cycle... they say that they dropped Node 8 in 26.0 but then they require 10.X in point releases and then they downgrade it (jestjs/jest#10352) to 10.13, but only in the worker, so here we are. |
krassowski
force-pushed
the
add-sql-server
branch
from
80008f3
to
550e34a
Compare
krassowski
force-pushed
the
add-sql-server
branch
from
17777ae
to
c6272e7
Compare
py_src/jupyter_lsp/specs/__init__.py
Outdated
| from .bash_language_server import BashLanguageServer | ||
| from .dockerfile_language_server_nodejs import DockerfileLanguageServerNodeJS | ||
| from .javascript_typescript_langserver import JavascriptTypescriptLanguageServer | ||
| from .pyls import PythonLanguageServer | ||
| from .r_languageserver import RLanguageServer | ||
| from .sql_langserver import SQLLanguageServer |
There was a problem hiding this comment.
maybe make sql_language_server for consistency....
There was a problem hiding this comment.
I was also thinking whether we need to have nodejs prefix on DockerfileLanguageServerNodeJS etc. I guess that it might have been used to distinguish potential alternative implementations, right?
There was a problem hiding this comment.
And more user-facing, we could change the display name of vscode-html-languageserver-bin to (at least) remove -bin suffix.
|
Modulo the one comment regarding the spec module name, which is not a blocker, LGTM. Heroic work on the RTD node stuff 👏 👏 👏 ... can't wait until Lab 3.0 makes it less of a life-ruining end-user experience, though of course we're rather wedded to it... for now. Before the next release, we should have a dedicated burn-down-the-yarn-lock party and figure out what is broken-by-default-unless-in-our-magic-garden. Potential follow-ons:
|
|
Interestingly, the tectonic Zlib error issue broke Windows 3.8 here (but the two other Windows builds proceeded normally)... So this is because it installed h4f32bc4_3 (bot other Windows runs used h11def9f_0). I feel i understand the way conda/mambda resolves dependencies less and less... (though this is still an upstream bug...) |
References
Closes #325 . Provides a default connection configuration using an empty in-memory SQLite3 database so that it works straight away. It's simple on features (completion + diagnostics) and the diagnostics do not really work on Node 10 as code uses features only implemented in Node 11 (see joe-re/sql-language-server#56), but we might be fine bumping the node requirement soon I think.
Code changes
None
User-facing changes
None
Backwards-incompatible changes
None
Chores