Make operations on NamespacedHierarchicalStore fail if it's closed
#3800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrannen
changed the title
NamespacedHierarchicalStore fail if it's closed
sbrannen
requested changes
Apr 29, 2024
...ngine/src/main/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStore.java
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStore.java
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStore.java
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStore.java
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStore.java
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStore.java
Outdated
Show resolved
Hide resolved
...ngine/src/main/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStore.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStoreTests.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStoreTests.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/junit/platform/engine/support/store/NamespacedHierarchicalStoreTests.java
Outdated
Show resolved
Hide resolved
3 tasks
mobounya
force-pushed
the
bug-fail_on_mods_after_close
branch
from
9976b4e
to
a49e575
Compare
sbrannen
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Thanks for making the requested changes.
All that's missing now is an entry in the release notes.
So, please add a release note here: https://github.com/junit-team/junit5/blob/main/documentation/src/docs/asciidoc/release-notes/release-notes-5.11.0-M2.adoc#new-features-and-improvements-1
Track the active/closed state in NamespacedHierarchicalStore so it can throw an IllegalStateException when doing a modification/query on it after it has been already closed. Make a close operation on an already closed store a no-op. Issue: junit-team#3614
mobounya
force-pushed
the
bug-fail_on_mods_after_close
branch
from
a49e575
to
67a289b
Compare
sbrannen
approved these changes
May 1, 2024
|
FYI: this has been further revised in d6a6eb8 to address two bugs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Track the active/closed state in NamespacedHierarchicalStore so it can throw an IllegalStateException when doing a modification/query on it after it has been already closed.
Make a close operation on an already closed store a no-op.
Issue: #3614
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotationsDeliverables
NamespacedHierarchicalStoretracks its active/closed stateNamespacedHierarchicalStorethrows an exception for modification or query calls after it has been closedNamespacedHierarchicalStore.close()is idempotent