Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify test method discovery and supported formats in User Guide (CLI) #3752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rcasia
Copy link

@rcasia rcasia commented Apr 1, 2024

Issue: #3748

Overview

This PR adds clarity to the usage of test methods with the --select-method argument for CLI users.


I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Apr 2, 2024

I think this is a good suggestion.

But I'm not part of the JUnit Team, so I can't say anything with authority. Usually they'll ask for contributions, or if it is small stuff, to avoid the back and forth they'll do it directly.

That said, I think it would help if:

  • The formatting in the issue was fixed.
  • There was an actual changelog item.

@sbrannen
Copy link
Member

sbrannen commented Apr 7, 2024

If we are going to be more explicit about the syntax for method selectors, we should also be more explicit about other selectors: packages, classes, etc.

For example, those all have to be "fully-qualified".

@sbrannen
Copy link
Member

sbrannen commented Apr 7, 2024

That said, I think it would help if:

* The formatting in the issue was fixed.

* There was an actual changelog item.

I agree with both of those points.

The formatting should align with the existing formatting (line breaks, etc.) in the same file.

This would warrant a minimal entry in the release notes.

@marcphilipp marcphilipp self-requested a review April 19, 2024 12:32
@marcphilipp marcphilipp modified the milestones: 5.11 M1, 5.11 M2 Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants