Introduce new DynamicTests generators in class DynamicTest #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new interface NamedExecutable that associates a name, a payload and an Executable. This was introduced to help colocate test's diplayName, payload, and testExecutor in one place. Concrete usage of this interface is in the next commit. Issue: junit-team#3261
Introduce two methods in the class DynamicTest to generate a stream of DynamicTests from a Stream/Iterator of NamedExecutables. Instead of passing an inputStream, a displayNameGenerator and a testExecutor separately, these two additional methods will allow you to pass one Iterator/Stream of a NamedExecutable. Unlike the Named interface, the NamedExecutable can colocate assertion callbacks in one container using the execute method. Issue: junit-team#3261
Write new changes to the release notes for 5.11M1 and add a simple demo in DynamicTestsDemo. Issue: junit-team#3261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Introduce new interface
NamedExecutableand two additional methods in DynamicTest<T extends NamedExecutable<T>> Stream<DynamicTest> stream(Stream<? extends NamedExecutable<T>> inputStream)and<T extends NamedExecutable<T>> Stream<DynamicTest> stream(Iterator<? extends NamedExecutable<T>> inputGenerator).This will hopefully resolve Issue #3261: Simplify implementation of self-contained dynamic tests
Supersedes #3651
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations