Feature/TestFactory Kotlin Sequence support #3377
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanszt
force-pushed
the
feature/testfactory-kotlin-sequence-support
branch
10 times, most recently
from
8a0a767
to
52d6c31
Compare
hanszt
changed the title
2 tasks
marcphilipp
requested changes
Jul 7, 2023
junit-platform-commons/src/main/java/org/junit/platform/commons/util/CollectionUtils.java
Outdated
Show resolved
Hide resolved
junit-platform-commons/src/main/java/org/junit/platform/commons/util/CollectionUtils.java
Outdated
Show resolved
Hide resolved
hanszt
force-pushed
the
feature/testfactory-kotlin-sequence-support
branch
from
52d6c31
to
f32d798
Compare
|
Hello, I am curious if my changes in response to the review satisfy the requirements. I would love to hear what you think and if it can be merged to the main branch |
Examples of benefits: - Kotlin Sequence support for @testfactory - Kotlin Sequence support for @MethodSource Classes that expose an Iterator returning method, can be converted to a stream. ```markdown --- I hereby agree to the terms of the JUnit Contributor License Agreement. ```
hanszt
force-pushed
the
feature/testfactory-kotlin-sequence-support
branch
from
f32d798
to
9e7a9a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding support for converting iterator providing classes to a stream in org.junit.platform.commons.util.CollectionUtils.
See also Add kotlin Sequence support for @TestFactory annotated methods
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations