New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configuration parameters resources #3345
base: main
Are you sure you want to change the base?
Add support for configuration parameters resources #3345
Conversation
This commit adds support for specifying a properties file, for use with configuration parameters. - Added a new field configurationParametersResources of type List<String> to store the configuration parameters resources. - Added new methods configurationParametersResource(String propertiesFile) and configurationParametersResources(List<String> propertiesFiles) to add configuration parameters resources to the request builder. - Updated the buildLauncherConfigurationParameters() method to include the configurationParametersResources in the Builder instance. Related to issue: junit-team#3340
Question: I seem to have forgot about the picocli console runner. Should I add new picocli options for selecting a config resource file? ( |
Yes, that sounds like a good idea. Though maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the PR.
I requested a few minor changes.
...launcher/src/main/java/org/junit/platform/launcher/core/LauncherDiscoveryRequestBuilder.java
Outdated
Show resolved
Hide resolved
...rm-suite-api/src/main/java/org/junit/platform/suite/api/ConfigurationParametersResource.java
Outdated
Show resolved
Hide resolved
...rc/test/java/org/junit/platform/suite/commons/SuiteLauncherDiscoveryRequestBuilderTests.java
Outdated
Show resolved
Hide resolved
...rm-suite-api/src/main/java/org/junit/platform/suite/api/ConfigurationParametersResource.java
Outdated
Show resolved
Hide resolved
Or just make
Edit: Nevermind, I don't think it applies to this anyway. The launcher request builder is used from here, so the logic will be the same regardless. |
e5ff689
to
628a605
Compare
Adjusted annotation parameter name to `value()`. Scrapped duplicate configurationParametersResources method on discovery request builder. (Is now var-args)
628a605
to
1d12ffc
Compare
Ping @sbrannen, do you have time to check my fixes to your requested changes? |
Overview
This commit adds support for specifying a properties file, for use with configuration parameters.
Related to issue: #3340
Open questions:
The@API
annotation values, what should they be? Are they experimental or set to STABLE at once? Which version nr?I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations