Add assertEquals with BinaryPredicate #2965

jbee · 2022-07-05T17:05:29Z

Overview

Initial PR for #2964

I hereby agree to the terms of the JUnit Contributor License Agreement.

There are no TODOs left in the code
Method preconditions are checked and documented in the method's Javadoc
Coding conventions (e.g. for logging) have been followed
Change is covered by automated tests including corner cases, errors, and exception handling
Public API has Javadoc and @API annotations
Change is documented in the User Guide and Release Notes
All continuous integration builds pass

gilbertojrequena · 2022-07-07T08:17:33Z

junit-jupiter-engine/src/test/java/org/junit/jupiter/api/AssertEqualsAssertionsTests.java

+
+	@Test
+	void assertEqualsWithBinaryPredicateBigDecimalFail() {
+		try {


I think in this cases you can use org.assertj.core.api.Assertions.assertThatThrownBy

marcphilipp · 2022-07-08T15:02:59Z

@jbee Thanks for the PR but we decided to decline the corresponding issue with the rationale outlined in #2964 (comment).

jbee added 3 commits July 5, 2022 19:04

Add assertEquals with BinaryPredicate

1edb76b

Fix imports and test names

7cff1d9

Fix add missing annotations

4bb0229

gilbertojrequena reviewed Jul 7, 2022

View reviewed changes

marcphilipp closed this Jul 8, 2022