Fix test "threadGroupNotLeaked" #1689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
approved these changes
Jan 2, 2021
kcooney
reviewed
Jan 2, 2021
| @@ -212,7 +212,7 @@ private void notTheRealCauseOfTheTimeout() { | |||
| public void threadGroupNotLeaked() throws Throwable { | |||
There was a problem hiding this comment.
This test is being replaced in pull 1687
Based on the CI run, I suspect that it's flaky anyway.
The FailOnTimeout statement was not executed because the Runnable's "run" method was not called.
stefanbirkner
force-pushed
the
thread-group-not-leaked
branch
from
7bd2396
to
589f2ba
Compare
|
Obsolete because test changed in #1687. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FailOnTimeout statement was not executed because the Runnable's
"run" method was not called.