Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed eclipse config files and added them to gitignore #1562

Closed
wants to merge 1 commit into from
Closed

Removed eclipse config files and added them to gitignore #1562

wants to merge 1 commit into from

Conversation

lbroman
Copy link

@lbroman lbroman commented Oct 11, 2018

It is considered bad practice to handle IDE configuration in GIT so I have cleaned up the eclipse files and added them to the ignore file.

If you have policies to keep eclipse files specifically, please feel free to ignore my pull request.

@kcooney
Copy link
Member

kcooney commented Oct 12, 2018

I personally use the checked-in eclipse files. JUnit also often gets contributions from less-experianced developers that do not know how to import projects into Eclipse without the project files.

At the very least if we remove the files we should provide documentation on how to generate them or otherwise get started with Eclipse and IntelliJ.

@lbroman
Copy link
Author

lbroman commented Oct 12, 2018

Good point. I can write a simple guide on how to get started with Eclipse and maven. Is this something that should be on the github wiki or in the source tree?

@panchenko
Copy link
Contributor

To be honest: there is no need to change anything.
Why fixing something that's not broken?

@lbroman
Copy link
Author

lbroman commented Oct 12, 2018

Depends on your view on if unclean is broken or not. Or what is even an unclean project. I'm don't think I have any say on that in this project anyway. Feel free to close my pull request.

@kcooney
Copy link
Member

kcooney commented Oct 13, 2018

If we want to add documentation about working with Eclipse, I suggest updating https://github.com/junit-team/junit4/blob/master/CONTRIBUTING.md

Currently the Eclipse files specify dependencies that are already listed in the pom, so checking them in does violate Don't Repeat Yourself. So there are some minor advantages to removing them.

That being said, I wouldn't expect the dependencies to change, since 4.13 is likely to be the last release of the 4.x code line.

@Tibor17
Copy link
Contributor

Tibor17 commented Nov 15, 2018

IDE settings should not be committed if you use Maven.
Every intelligent tool extracts the project settings from POM.
So. This commit is acceptable and if you see #1545, the unrelated changes which are human mistakes could be clearly avoided with this PR.

@marcphilipp marcphilipp changed the base branch from master to main June 21, 2020 17:05
@wangminpku
Copy link

Dear lbroman (@lbroman )and Junit team (@kcooney)(@marcphilipp )(@stefanbirkner ) (@panchenko )(@Tibor17 )(@aslakhellesoy )

We are working on automatically identifying and clustering the related pull requests for code review. We have found that PR#821 might be related to this one, because both of them focus on the same problem.

We would really appreciate it if you could help us to validate and give us some feedback if the information from PR#821 is helpful when you review the current PR.

Thank you very much for your time!

@marcphilipp
Copy link
Member

Closing due to lack of consensus and inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants