New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish documentation #690
Polish documentation #690
Conversation
@jbduncan I made a bunch of changes to the resource and temp dir documentations. Would be nice if you had the time to look them over. 😃 |
I didn't want to open that topic, bus as you did: Did you consider working on accessibility? 🙈 |
I just ran two tools and the website is looking ok. Since there are serious considerations to replace it with something else (see junit-pioneer/junit-pioneer.github.io#26), I would not spend much time on it now. |
it looks okay except the hundres of contrast issue, from the code examples (as we also use asciidoc we have to search for a correct code style renderer [which is not task of asciidoc]), the layout tables and so on. But yeah we can tackle this in a different issue and focus here on content. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvements, @nipafx! Just a small number of typos and clarifying questions, then I'd be totally happy.
src/demo/java/org/junitpioneer/jupiter/params/RangeSourcesDemo.java
Outdated
Show resolved
Hide resolved
As I see it, this is ready to merge. Let's run the full build and if nobody has any concerns, a maintainer can merge it. |
@nipafx LGTM! |
Proposed commit message:
PR checklist
The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.
Documentation (general)
.adoc
file in thedocs
folder, e.g.docs/report-entries.adoc
.adoc
file references demo insrc/demo/java
instead of containing code blocks as text.adoc
files)Documentation (new extension)
docs/docs-nav.yml
navigation has an entry for the new extensionpackage-info.java
contains information about the new extensionCode
Contributing
README.md
mentions the new contribution (real name optional)