Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish documentation #690

Merged
merged 10 commits into from Nov 17, 2022
Merged

Polish documentation #690

merged 10 commits into from Nov 17, 2022

Conversation

nipafx
Copy link
Member

@nipafx nipafx commented Nov 15, 2022

Proposed commit message:

Polish documentation (#681, #685 / #690)

* improve project description
* improve article titles, descriptions, and first paragraph (~> #681)
* sort navigation by title
* fix broken internal links
* use `====` for multi-line admonition boxes
* many small improvements (~> #685)

Closes: #681, #685
PR: #690

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Documentation (new extension)

  • The docs/docs-nav.yml navigation has an entry for the new extension
  • The package-info.java contains information about the new extension

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists
  • The list of contributions inside README.md mentions the new contribution (real name optional)

@nipafx
Copy link
Member Author

nipafx commented Nov 15, 2022

@jbduncan I made a bunch of changes to the resource and temp dir documentations. Would be nice if you had the time to look them over. 😃

@Bukama
Copy link
Member

Bukama commented Nov 16, 2022

I didn't want to open that topic, bus as you did: Did you consider working on accessibility? 🙈

@nipafx
Copy link
Member Author

nipafx commented Nov 16, 2022

I just ran two tools and the website is looking ok. Since there are serious considerations to replace it with something else (see junit-pioneer/junit-pioneer.github.io#26), I would not spend much time on it now.

@Bukama
Copy link
Member

Bukama commented Nov 16, 2022

it looks okay except the hundres of contrast issue, from the code examples (as we also use asciidoc we have to search for a correct code style renderer [which is not task of asciidoc]), the layout tables and so on. But yeah we can tackle this in a different issue and focus here on content.

Copy link
Contributor

@jbduncan jbduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements, @nipafx! Just a small number of typos and clarifying questions, then I'd be totally happy.

docs/temp-directory.adoc Outdated Show resolved Hide resolved
docs/resources.adoc Show resolved Hide resolved
docs/resources.adoc Show resolved Hide resolved
@nipafx
Copy link
Member Author

nipafx commented Nov 17, 2022

@jbduncan I added tests to verify the correct cleanup behavior in b11815a.

@nipafx
Copy link
Member Author

nipafx commented Nov 17, 2022

As I see it, this is ready to merge. Let's run the full build and if nobody has any concerns, a maintainer can merge it.

@nipafx nipafx added the full-build Triggers full build suite on PR label Nov 17, 2022
@Michael1993 Michael1993 merged commit 8c2aa67 into main Nov 17, 2022
@Michael1993 Michael1993 deleted the issue/681-docs-seo branch November 17, 2022 13:01
@jbduncan
Copy link
Contributor

@nipafx LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-build Triggers full build suite on PR
Projects
None yet
4 participants