Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename label "merge-ready" to "full-build" (#679 / #682) #682

Merged
merged 1 commit into from Nov 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Expand Up @@ -108,9 +108,9 @@ jobs:
# Our full integration job, which will build for a matrix out of our supported
# Java versions, operating systems, modular or not, and various JUnit versions.
# This build is executed on all tags and the default branch. Furthermore, we will
# also execute this for pull requests with the label `merge-ready`.
# also execute this for pull requests with the label `full-build`.
full-featured:
if: (contains(github.event.pull_request.labels.*.name, 'merge-ready') || !github.event.pull_request)
if: (contains(github.event.pull_request.labels.*.name, 'full-build') || !github.event.pull_request)
needs: basic
runs-on: ${{ matrix.os }}-latest
timeout-minutes: 15
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
# Furthermore, we also would love to see our build working with the latest Gradle version.
# As those builds might fail, they are allowed to fail, and should not prevent merges.
experimental:
if: (contains(github.event.pull_request.labels.*.name, 'merge-ready') || !github.event.pull_request)
if: (contains(github.event.pull_request.labels.*.name, 'full-build') || !github.event.pull_request)
needs: full-featured
runs-on: ${{ matrix.os }}-latest
continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Expand Up @@ -391,7 +391,7 @@ To enforce the [branching strategy](#branching-strategy) pull requests from `mai
### Full Testing

In order to minimize the delay between a push and feedback, the default build is only run on a small subset of all possible builds (which include different operating system, Java versions and so on).
Once a pull request is ready to be merged, a maintainer needs to apply the _merge-ready_ label to trigger a full build.
To get more wider feedback, for example once a pull request is ready to be merged, a maintainer needs to apply the _full-build_ label to trigger just that.

### Merging

Expand Down