Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StdErr to StdIoExtension #653

Merged
merged 6 commits into from Aug 11, 2022
Merged

Add StdErr to StdIoExtension #653

merged 6 commits into from Aug 11, 2022

Conversation

Michael1993
Copy link
Member

@Michael1993 Michael1993 commented Jul 26, 2022

Closes #650

Proposed commit message:

Add StdErr to StdIoExtension (#650 / #653)

Adds a new parameter to the StdIoExtension, StdErr, which
replaces System.err the same way StdOut replaces
System.out.

Closes: #650
PR: #653

PR checklist

The following checklist shall help the PR's author, the reviewers and maintainers to ensure the quality of this project.
It is based on our contributors guidelines, especially the "writing code" section.
It shall help to check for completion of the listed points.
If a point does not apply to the given PR's changes, the corresponding entry can be simply marked as done.

Documentation (general)

  • There is documentation (Javadoc and site documentation; added or updated)
  • There is implementation information to describe why a non-obvious source code / solution got implemented
  • Site documentation has its own .adoc file in the docs folder, e.g. docs/report-entries.adoc
  • Site documentation in .adoc file references demo in src/demo/java instead of containing code blocks as text
  • Only one sentence per line (especially in .adoc files)
  • Javadoc uses formal style, while sites documentation may use informal style

Code

  • Code adheres to code style, naming conventions etc.
  • Successful tests cover all changes
  • There are checks which validate correct / false usage / configuration of a functionality and there are tests to verify those checks
  • Tests use AssertJ or our own PioneerAssert (which are based on AssertJ)

Contributing

  • A prepared commit message exists

@Michael1993
Copy link
Member Author

I did a lazy thing with the documentation. 😬 Let me know if this is okay.

Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few notes, you may consider (or not :D ). Thanks for PR!

docs/standard-input-output.adoc Outdated Show resolved Hide resolved
docs/standard-input-output.adoc Outdated Show resolved Hide resolved
docs/standard-input-output.adoc Outdated Show resolved Hide resolved
@Michael1993 Michael1993 requested a review from Bukama July 30, 2022 10:18
Copy link
Member

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :) Nice PR

@Michael1993 Michael1993 merged commit 9fa2a20 into main Aug 11, 2022
@Michael1993 Michael1993 deleted the issue/650-system-err branch August 11, 2022 06:38
Michael1993 added a commit that referenced this pull request Aug 11, 2022
Michael1993 added a commit that referenced this pull request Aug 11, 2022
Adds a new parameter to the StdIoExtension, StdErr, which
replaces System.err the same way StdOut replaces
System.out.

Closes: #650
PR: #653
Bukama pushed a commit to Bukama/junit-pioneer that referenced this pull request Sep 20, 2022
Adds a new parameter to the StdIoExtension, StdErr, which
replaces System.err the same way StdOut replaces
System.out.

Closes: junit-pioneer#650
PR: junit-pioneer#653
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add StdErr to StdIoExtension
3 participants