Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Checkstyle and JaCoCo to fix build #637

Merged
merged 6 commits into from
May 19, 2022
Merged

Update Checkstyle and JaCoCo to fix build #637

merged 6 commits into from
May 19, 2022

Commits on May 18, 2022

  1. Update Checkstyle from 7.8.2 to 10.2

    @beatngu13
    beatngu13 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    6ebb4ac View commit details
    Browse the repository at this point in the history

  2. Sync tag ending style

    @beatngu13
    beatngu13 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    1e80a86 View commit details
    Browse the repository at this point in the history

  3. Remove deleted properties 

    >properties `allowMissingThrowsTags`, `allowUndeclaredRTE` [...] should
>be just removed from configs.
>Behavior will change as there will be less violations in code, such
>properties did not work well so their removal should be ok, as there
>will be less false-positives.

See:

* https://checkstyle.sourceforge.io/releasenotes.html#Release_8.28
* checkstyle/checkstyle#7329
    @beatngu13
    beatngu13 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    24efb22 View commit details
    Browse the repository at this point in the history

  4. Remove replaced property 

    Replaced by
[`MissingJavadocMethod`](https://checkstyle.org/config_javadoc.html#MissingJavadocMethod).
That is, missing Javadoc is now allowed by default.

See:

* https://checkstyle.sourceforge.io/releasenotes.html#Release_8.21
* checkstyle/checkstyle#6703
    @beatngu13
    beatngu13 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    4e65b59 View commit details
    Browse the repository at this point in the history

  5. Remove validateThrows 

    Since the property `allowMissingThrowsTags` has been removed,
`validateThrows` now means you can no longer omit `@throws` in Javadoc.
Whenever a method declares `throws`, it must be documented.

Furthermore, Checkstyle authors say:

>If you need to validate `@throws` please enable property
>`validateThrows but please read documentation as there some
>limitations -
>https://checkstyle.org/config_javadoc.html#JavadocMethod .
>Old documentation is at
>https://checkstyle.sourceforge.io/version/8.27/config_javadoc.html#JavadocMethod
    @beatngu13
    beatngu13 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    78c12a5 View commit details
    Browse the repository at this point in the history

  6. Update JaCoCo from 0.8.7 to 0.8.8 

    To handle Java 18 bytecode (version 62).
    @beatngu13
    beatngu13 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    ddf161a View commit details
    Browse the repository at this point in the history