-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to AsciiDoc snippets (#595 / #632) #632
Migrate to AsciiDoc snippets (#595 / #632) #632
Conversation
@@ -260,6 +260,7 @@ tasks { | |||
dependencies { | |||
implementation(project) | |||
implementation("com.fasterxml.jackson.core:jackson-databind:$jacksonVersion") | |||
implementation("org.assertj:assertj-core:3.22.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems not to work as assertThat
is not found during compile (but by IntelliJ) in demo sources
Aside the fact that |
Fixed it. Now the build fails because some of the demos fail at run time. Intentionally, I think, but that means those failing demos must be pulled into nested classes that aren't marked as |
Thank you. I moved the failing tests to inner classes and the build successfully runs now (at least local). One thing I noticed: As for the demo the same spotless/checkstyle rules are applied the code is intended. These intention is then also applied to the documentation. Same for all other formatting, which results in longer code lines than we had before after applying #317. |
You need to add include::{json-demo}[tag=classpath_source,indent=0] |
Thank you very much, Bish! ❤️ |
Migrate all demo code to AciiDoc snippets to let them be compiled. Intentionally failing tests are moved to inner classes to prevent test execution. Closes: junit-pioneer#595 PR: junit-pioneer#632
Proposed commit message: